Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds go vet analyzers in CI #67

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Jan 10, 2024

Enable all go vet analyzers in CI
Fixes nilness and fieldalignment check

Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
@onf-bot
Copy link
Contributor

onf-bot commented Jan 10, 2024

Can one of the admins verify this patch?

1 similar comment
@onf-bot
Copy link
Contributor

onf-bot commented Jan 10, 2024

Can one of the admins verify this patch?

Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
@gab-arrobo
Copy link
Contributor

ok to test

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run an end-to-end test to make sure that proposed changes do not break anything?

factory/config.go Show resolved Hide resolved
httpcallback/router.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (tested changes with AiaB)

factory/config.go Show resolved Hide resolved
@gab-arrobo gab-arrobo merged commit fe14035 into omec-project:master Jan 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants